Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Base paymaster actions #51

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

lukasrosario
Copy link

Copy link

changeset-bot bot commented Dec 11, 2023

🦋 Changeset detected

Latest commit: 76de2d5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
permissionless Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lukasrosario lukasrosario force-pushed the lukas/add-base-paymaster branch from 154dcfa to 17a2611 Compare January 5, 2024 16:57
@lukasrosario lukasrosario changed the title [wip] add Base paymaster support [wip] add Base paymaster actions Jan 5, 2024
@lukasrosario lukasrosario changed the title [wip] add Base paymaster actions add Base paymaster actions Jan 5, 2024
@lukasrosario lukasrosario marked this pull request as ready for review January 5, 2024 17:48
@lukasrosario
Copy link
Author

@plusminushalf @kristofgazso hey! wondering if there's anything else needed to get this in? happy to make any edits.

@plusminushalf
Copy link
Contributor

Hey will check this in a day or two

@kristofgazso
Copy link
Contributor

Hey @lukasrosario! We've been thinking internally whether it makes sense to have this as a part of the core permissionless.js package.

Alternative is to publish this as part of a different package like @permissionless/base-paymaster or something similar which can easily be imported by users if needed but given this is a more niche usecase, would not bloat the core SDK.

Will get back soon! Regardless thank you very much for the contribution and definitely would love to see this as part of the permissionless.js ecosystem one way or the other

@lukasrosario
Copy link
Author

cool thank you both for getting back to me, lmk if there's anything I can do to help

@plusminushalf
Copy link
Contributor

Hey @lukasrosario is this still relevant? Given coinbase paymaster service is Eip7677 compatible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants